async_hooks: merge resource_symbol with owner_symbol#38468
Closed
RaisinTen wants to merge 1 commit intonodejs:masterfrom
Closed
async_hooks: merge resource_symbol with owner_symbol#38468RaisinTen wants to merge 1 commit intonodejs:masterfrom
RaisinTen wants to merge 1 commit intonodejs:masterfrom
Conversation
github-actions
bot
added
async_hooks
Member
Author
|
cc @addaleax |
addaleax
approved these changes
Apr 30, 2021
RaisinTen
commented
Apr 30, 2021
RaisinTen
commented
Apr 30, 2021
Trott
approved these changes
May 2, 2021
Qard
reviewed
May 10, 2021
Signed-off-by: Darshan Sen <darshan.sen@postman.com>
RaisinTen
force-pushed
the
async_hooks/merge-resource_symbol-with-owner_symbol
branch
from
aa99773 to
8fa2b28
Compare
This comment has been minimized.
This comment has been minimized.
addaleax
approved these changes
Jul 26, 2021
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
👍
I know that the constructor name checks may seem a bit icky here, but I think in the big picture doing this is definitely worth it 👍
RaisinTen
added
the
author ready
This comment has been minimized.
This comment has been minimized.
Collaborator
jasnell
approved these changes
Jul 26, 2021
Member
Author
|
cc @nodejs/async_hooks if anyone else would also like to take a look. |
benjamingr
approved these changes
Jul 27, 2021
Member
|
Landed in 7ca2f13 |
jasnell
pushed a commit
that referenced
this pull request
Jul 28, 2021
Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #38468 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
RaisinTen
deleted the
async_hooks/merge-resource_symbol-with-owner_symbol
branch
danielleadams
pushed a commit
that referenced
this pull request
Aug 16, 2021
Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #38468 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Contributor
|
This breaks AsyncLocalStorage for TCP/TLS sockets. See #40693. |
This was referenced Jun 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per this TODO comment:
node/lib/internal/async_hooks.js
Lines 182 to 183 in 6ca785b